Fix Rollout Scorer azure function not picking up issues #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonfortescue
requested review from
alexperovich,
ChadNedzlek,
sunandabalu,
riarenas and
missymessa
jonfortescue
force-pushed
the
FixTimeZoneBug
branch
from
dc335d5
to
c2c31d7
Compare
ChadNedzlek
reviewed
Jul 8, 2020
sunandabalu
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
LGTM . Thanks to @ChadNedzlek for getting to a simpler implementation :)
ChadNedzlek
approved these changes
Jul 9, 2020
|
@sunandabalu Added the piece about issue checking we discussed. |
ChadNedzlek
approved these changes
Jul 17, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
meganaquinn
pushed a commit
to meganaquinn/arcade-services
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/core-eng#10188.
Problem is described in this comment: https://github.com/dotnet/core-eng/issues/10188#issuecomment-655442868
I just switch us to offset UTC-1 to avoid the issue described above.Per Chad's suggestion, just upgraded the package.Also added new route for detecting failures (if last build is a rollback, rollout failed).